-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(files): support nested actions #41010
Conversation
skjnldsv
commented
Oct 20, 2023
•
edited
Loading
edited
- Fix Add API for FileAction submenu actions #39718
- Needs feat: support nested actions nextcloud-libraries/nextcloud-files#814
- Needs 3.0.0-beta.27 nextcloud-libraries/nextcloud-files#823
- Needs 8.0.0-beta.10 nextcloud-libraries/nextcloud-vue#4754
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
9dbac0d
to
d1db634
Compare
d1db634
to
c107174
Compare
@Pytal please review the logic! Especially the condition on where a reminder is shown or not, as I wasn't part of the original discussions! I used your services, so I think it should be good.
|
c107174
to
d0290e3
Compare
Yes this is by design
Yes, if you can see (read) the file then you should be able to set a reminder on it |
apps/files_reminders/src/actions/setReminderSuggestionActions.scss
Outdated
Show resolved
Hide resolved
apps/files_reminders/src/actions/setReminderSuggestionActions.ts
Outdated
Show resolved
Hide resolved
apps/files_reminders/src/actions/setReminderSuggestionActions.ts
Outdated
Show resolved
Hide resolved
dcf6e36
to
d5371bd
Compare
d5371bd
to
48a5e4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The focus handling does not work properly:
If you click (keyboard) on "set reminder" the submenu opens but the focus is not set on the submenu's first element.
Also if you click the back button the first submenu is reopend, but the focus is not on the "set reminder" entry.
In both cases the focus is on some random non visible element.
} | ||
|
||
// Generate the default preset actions | ||
export const actions = [laterToday, tomorrow, thisWeekend, nextWeek] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the presence of the action should be evaluated ideally on click instead of on script execution I think the FileAction enabled callback needs to be set to something like () => Boolean(getDateTime(option.dateTimePreset))
to be more reactive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be improved later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘 a11y in follow up?
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
48a5e4d
to
32c1aeb
Compare