Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a dialog for custom date form instead of including it in the action menu #10202

Open
marcoambrosini opened this issue Aug 14, 2023 · 14 comments

Comments

@marcoambrosini
Copy link
Member

marcoambrosini commented Aug 14, 2023

Including baby forms within action menus is a recurring pattern in Nextcloud and it's one that I think we should break. We shouldn't include forms, especially if they involve multi-selects and pickers, into tiny action menus.
When there's the need of a form we can add an action button that brings up a dialog or opens the form somewhere else.
Having a text input with an inline submit button is probably ok but still not ideal IMO.

In this particular case we have a baby form with a submit button that looks exactly like an action buttons above, creating visual confusion and usability issues. For example here there's no way to guarantee that the picker itself won't block the button to submit the form itself once you've chosen the date. (see screenshot)

This came up in a recent design call and there was some consensus on that we should probably even deprecate these complex action input elements. What do you think @nextcloud/designers ??

Screenshot 2023-08-09 at 17 38 06

Originally posted by @marcoambrosini in #10105 (comment)

@marcoambrosini marcoambrosini changed the title To elaborate on [my point above](https://github.com/nextcloud/spreed/pull/10105#pullrequestreview-1564772478): Remove baby form from reminder tooltip and use a dialog instead Aug 14, 2023
@nickvergessen
Copy link
Member

This solution already existed in the mail app with the send later functionality and is planned to keep aligned between:

@marcoambrosini marcoambrosini changed the title Remove baby form from reminder tooltip and use a dialog instead Use a dialog for custom date form instead of including it in the action menu Aug 14, 2023
@nickvergessen nickvergessen added this to the 💔 Backlog milestone Aug 14, 2023
@marcoambrosini
Copy link
Member Author

I agree we should be consistent, but we should break this pattern and adopt a better one. This is another instance in mail:

Screenshot 2023-08-14 at 17 50 24

--

To provide a counter example. In the files reminders issue, Gmail was used as inspiration, but there clicking "pick date and time" in the action menu brings up a nice and tidy dialog where everything is clearly laid out.

Screenshot 2023-08-14 at 17 52 05

@jancborchardt
Copy link
Member

This seems to be an issue for the components library though, not only for Talk?

@marcoambrosini
Copy link
Member Author

The issue in the component library is that we have an actioninput type date.

@skjnldsv

This comment was marked as resolved.

@nickvergessen

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@nickvergessen

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@nickvergessen

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@marcoambrosini
Copy link
Member Author

@skjnldsv I mean putting the native date picker in a modal with confirmation button, so yes what Joas said above

@skjnldsv
Copy link
Member

skjnldsv commented Nov 7, 2023

image

@marcoambrosini
Copy link
Member Author

Beautiful @skjnldsv :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants