-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement direct editing API #2405
base: main
Are you sure you want to change the base?
Conversation
} | ||
|
||
public function getExtension(): string { | ||
return 'odp'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to check for the preferred default document format Open Document Format or Office Open XML and pick the extension / mime type depending on that as done here:
richdocuments/lib/TemplateManager.php
Line 459 in 9bb9661
$ooxml = $this->config->getAppValue(Application::APPNAME, 'doc_format', '') === 'ooxml'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call! Added this to the text/presetnation/spreadsheet creators.
Unsure what to do with the graphics one, as far as I know there is no odg
equivalent in Microsoft Office.
|
lib/DirectEditing/DirectEditor.php
Outdated
public function open(IToken $token): Response { | ||
$token->useTokenScope(); | ||
try { | ||
$session = $this->apiService->create($token->getFile()->getId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems there is still some logic missing here to make this work ;)
eeda34b
to
b909462
Compare
@Raudius I released and pushed a small typo fix for the namespace, but seems this is not in a functional state yet. Since you mentioned testing it locally, maybe you didn't push your recent changes? :) |
f8f4ba7
to
f229236
Compare
@juliushaertl Looks like I messed up when pushing this 🙈 Had to redo some of the changes but should be back to what I had before. Seems to work on the desktop client for me, but still unable to get the direct edit view to load on Andorid. |
I think we need a few more alignments for android/iOS. Currently the server side direct editing uses different post messages for emitting a status, so we probably should unify, standardise and document what we use and what is expected. For now only a writeup on what is currently there: https://github.com/nextcloud/text/blob/master/src/views/DirectEditing.vue#L50-L83 Richdocuments direct editing (old) (emitted by the web app)https://github.com/nextcloud/richdocuments/search?q=callMobileMessage
Server direct editing (emitted by the web app)https://github.com/nextcloud/text/blob/master/src/views/DirectEditing.vue#L107-L124
Interfaces called by the clients
Related text app issue nextcloud/text#1170 |
|
e355ea1
to
13897b2
Compare
Signed-off-by: Raul <[email protected]> Implement direct editing API Signed-off-by: Raul <[email protected]>
13897b2
to
9981fe3
Compare
Summary
Implements the direct editing API for mimetypes supporrted by Collabora.
TODO
Checklist