Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement direct editing API #721

Open
juliusknorr opened this issue Dec 2, 2019 · 6 comments · May be fixed by #2405
Open

Implement direct editing API #721

juliusknorr opened this issue Dec 2, 2019 · 6 comments · May be fixed by #2405
Labels
2. developing Work in progress enhancement New feature or request technical debt

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Dec 2, 2019

nextcloud/server#17625

@juliusknorr juliusknorr added enhancement New feature or request 1. to develop Waiting for a developer labels Dec 2, 2019
@juliusknorr juliusknorr added this to the 3.5.0 milestone Dec 2, 2019
@juliusknorr juliusknorr removed this from the 3.5.0 milestone Jan 25, 2020
@Raudius Raudius self-assigned this Aug 1, 2022
@Raudius Raudius added 2. developing Work in progress and removed 1. to develop Waiting for a developer labels Aug 1, 2022
@juliusknorr
Copy link
Member Author

From previous discussions, we need to verify the implementation on Desktop, Android and iOS, while desktop has higher probability to work out of the box as the others currently have existing special logic for office documents with Collabora.

@tobiasKaminsky
Copy link
Member

When you need help from our side, we are happy to help.
We can also have a short call between both of us to coordinate it.
Right now I am unsure what to check :)

@Raudius Raudius linked a pull request Aug 25, 2022 that will close this issue
5 tasks
@Raudius
Copy link
Contributor

Raudius commented Aug 25, 2022

When you need help from our side, we are happy to help. We can also have a short call between both of us to coordinate it. Right now I am unsure what to check :)

Sorry, forgot to push the PR! ;) #2405

I have tried testing it on Android but I cannot open the files (gets stuck on loading), however the endpoint seems to work when entered manually through the browser though. Also I believe the Android app has hardcoded support for creating office files (when Nextcloud office is installed).

@tobiasKaminsky
Copy link
Member

Android/clients need to switch to new endpoint then, I think.
So I will test to switch entire Collabora usage from richdocuments endpoint to directEditing, same like with Text, right?

@juliusknorr
Copy link
Member Author

  • We need to wait for clients to be released to push this as otherwise there might be duplicate direct editing in the clients with the old and new approach

@juliusknorr
Copy link
Member Author

This will be the shared library that also can be used to generate documentation on the message passing between clients and the different editor implementations:https://github.com/nextcloud/nextcloud-directediting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request technical debt
Projects
Status: 🧭 Planning evaluation (don't pick)
Development

Successfully merging a pull request may close this issue.

3 participants