refactor: Apply PHP5.6-7.3 rector sets #10128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
Sep 11, 2024
| @@ -25,7 +25,7 @@ public function testIt($content, $filename, $contentType) { | |||
| $this->assertArrayHasKey('Content-Type', $headers); | |||
| $this->assertEquals($contentType, $headers['Content-Type']); | |||
| $this->assertArrayHasKey('Content-Disposition', $headers); | |||
| $pos = strpos($headers['Content-Disposition'], $filename); | |||
| $pos = strpos($headers['Content-Disposition'], (string) $filename); | |||
There was a problem hiding this comment.
Interesting case: The type cast was added to avoid the deprecation warning if non-strings are passed to strpos. That does not apply here. I would prefer to type $content, $filename and $contentType and avoid the type cast.
kesselb
approved these changes
Sep 16, 2024
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
refactor/rector-php-sets
branch
from
7f85b38
to
3a2cefa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits can be reviewed one by one.
PHP7.4+ comes with lots of changes. We can do them later.