refactor: Apply PHP7.3 sets

Signed-off-by: Christoph Wurst <[email protected]>
nextcloud · Sep 17, 2024 · 3a2cefa · 3a2cefa
1 parent bfaddda
commit 3a2cefa
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/rector.php b/rector.php
@@ -22,5 +22,5 @@
 		phpunit: true,
 	)
 	->withPhpSets(
-		php71: true,
+		php73: true,
 	);
diff --git a/tests/Unit/Http/AttachmentDownloadResponseTest.php b/tests/Unit/Http/AttachmentDownloadResponseTest.php
@@ -14,11 +14,8 @@
 class AttachmentDownloadResponseTest extends TestCase {
 	/**
 	 * @dataProvider providesResponseData
-	 * @param $content
-	 * @param $filename
-	 * @param $contentType
 	 */
-	public function testIt($content, $filename, $contentType) {
+	public function testIt(string $content, string $filename, string $contentType) {
 		$resp = new AttachmentDownloadResponse($content, $filename, $contentType);
 		$headers = $resp->getHeaders();
 		$this->assertEquals($content, $resp->render());

diff --git a/tests/Unit/Http/ProxyDownloadResponseTest.php b/tests/Unit/Http/ProxyDownloadResponseTest.php
@@ -25,7 +25,7 @@ public function testIt($content, $filename, $contentType) {
 		$this->assertArrayHasKey('Content-Type', $headers);
 		$this->assertEquals($contentType, $headers['Content-Type']);
 		$this->assertArrayHasKey('Content-Disposition', $headers);
-		$pos = strpos($headers['Content-Disposition'], $filename);
+		$pos = strpos($headers['Content-Disposition'], (string)$filename);
 		$this->assertTrue($pos > 0);
 	}