[stable4] feat: Refactor form sync to run as a background job with retry

[Koc]

This is backport of #2408 into stable4

[codecov]

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (stable4@270fc5a). Learn more about missing BASE report.
Report is 29 commits behind head on stable4.

Additional details and impacted files

@@            Coverage Diff             @@
##             stable4    #2424   +/-   ##
==========================================
  Coverage           ?   36.07%           
  Complexity         ?     1037           
==========================================
  Files              ?       72           
  Lines              ?     3947           
  Branches           ?        0           
==========================================
  Hits               ?     1424           
  Misses             ?     2523           
  Partials           ?        0           

[Koc]

I've tested success flow manually and it's LGTM ✅ .

Scenario:

1. created a form with short text question
2. submit 2 answers
3. link form with spreadsheet
4. submit one more answer
5. manually execute job using ./occ background-job:execute <job-id> --force-execute
6. the latest answer is present in spreadsheet

[Chartman123]

@Koc same here as for the other backport :) please add the changes to newSubmissionLegacy(), too

[Koc]

@Chartman123 ah, added

[Koc]

I hope nobody against of merging it:

• pipeline green
• code review comments fixed
• manual tests passed

[toad]

@Koc @Chartman123 This is still broken at least for existing shares post upgrading to 4.3.4, because it does not correctly handle the upgrade.

We get this error:
"Undefined array key "attempt" at /var/www/html/custom_apps/forms/lib/BackgroundJob/SyncSubmissionsWithLinkedFileJob.php#62"

We have patched it locally by changing SyncSubmissionsWithLinkedFileJob.php line 62 to:
$attempt = isset($argument['attempt']) ? ($argument['attempt'] ?: 1) : 1;

It might be a php version issue though?

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[Koc]

@toad strange, I've tested it locally before merge. It seems like

$attempt = $argument['attempt'] ?: 1;

should be replaced with

$attempt = $argument['attempt'] ?? 1;

can you open PR to fix that?