-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor form sync to run as a background job with retry #2408
Conversation
e08797f
to
493c3fe
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2408 +/- ##
=======================================
Coverage ? 44.27%
Complexity ? 860
=======================================
Files ? 73
Lines ? 3268
Branches ? 0
=======================================
Hits ? 1447
Misses ? 1821
Partials ? 0
|
493c3fe
to
d34796b
Compare
Added a fix for the issue described in #2067 |
d34796b
to
bc6bcab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :) I'd like to wait with the merging for @susnux's review
thanks for this PR, we can also do a backport to stable4, but you'll need to adjust the ApiController part there manually because of the duplicated routes.
/backport to stable4 |
The Codecov upload error isn't specific to Forms: codecov/codecov-action#1643 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure we need the max attempts, but otheriwse fine with me.
Please fix the code style in the constructor
7f49d49
to
dd86b4a
Compare
@susnux @Chartman123 I did requested changes. All pipelines are green except 2: PHPUnit SQLite + coverage upload. But tests pass |
Might be because you made changes on a branch in a fork that doesn't belong to you. It could also help to rebase to current main |
Already did by using Github UI button 🤷♂️ |
The codecov action was updated but they changed the syntax and we forgot to adjust it. |
Signed-off-by: ailkiv <[email protected]> Signed-off-by: Kostiantyn Miakshyn <[email protected]>
dd86b4a
to
10047d2
Compare
pipeline is completely green now ✔️ |
The backport to # Switch to the target branch and update it
git checkout stable4
git pull origin stable4
# Create the new backport branch
git checkout -b backport/2408/stable4
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 10047d28
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2408/stable4 Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
I will take care about backport to |
Nice, thank you :) |
here we go #2424 |
issue: #2165 , #2067
I implemented a logic to synchronize the form with the file, allowing multiple attempts if the first one fails. The process runs in the background with delays, ensuring it does not impact the user experience.