Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to notify when synced folder overcomes set size limit #5868

Merged
merged 57 commits into from
Aug 4, 2023
Merged

Add option to notify when synced folder overcomes set size limit #5868

merged 57 commits into from
Aug 4, 2023

Commits on Aug 4, 2023

  1. Const autofy variables in ProcessDirectoryJob::processFileAnalyzeRemo… 

    …teInfo

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    75f0e53 View commit details
    Browse the repository at this point in the history

  2. Clean up declaration of DiscoveryPhase::checkSelectiveSyncNewFolder b… 

    …y using const auto, renaming single letter variables, more

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    17de46c View commit details
    Browse the repository at this point in the history

  3. Move active folder size limit check to independent convenience method 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e5f399f View commit details
    Browse the repository at this point in the history

  4. Extract processServerNew into a proper method instead of large lambda 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e3dc6be View commit details
    Browse the repository at this point in the history

  5. Add DiscoveryPhase::checkSelectiveSyncExistingFolder 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7145d73 View commit details
    Browse the repository at this point in the history

  6. Check selective sync state directories that have been updated and now… 

    … have differing size

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5844b27 View commit details
    Browse the repository at this point in the history

  7. Use single convenience method to handle trailing slash in paths for F… 

    …older

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    ac218b0 View commit details
    Browse the repository at this point in the history

  8. Add slot for existing folders becoming big in Folder 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    10dd03f View commit details
    Browse the repository at this point in the history

  9. Create and connect specific signal for existing folder now being disc… 

    …overed to be big

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    6f2e63d View commit details
    Browse the repository at this point in the history

  10. Make checkFolderSizeLimit more task agnostic 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5acacdd View commit details
    Browse the repository at this point in the history

  11. Properly check folder size on server 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    aa20c10 View commit details
    Browse the repository at this point in the history

  12. Add a checkbox in UI to obey folder size limit for existing folders 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e8b8211 View commit details
    Browse the repository at this point in the history

  13. Add config settings for notifying existing folders going over limit 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    b06cbf4 View commit details
    Browse the repository at this point in the history

  14. Hook up existing folder notification size checkbox in general settings 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e6f5fb6 View commit details
    Browse the repository at this point in the history

  15. Do not notify if setting is not enabled for folders going over limit 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    6105733 View commit details
    Browse the repository at this point in the history

  16. Ensure notify big folders checkbox state is changed when parent check… 

    …box changes

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    83b6903 View commit details
    Browse the repository at this point in the history

  17. Do not notify about folders growing beyond threshold by default 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2a4ba39 View commit details
    Browse the repository at this point in the history

  18. Clean up AccountSettings::refreshSelectiveSyncStatus 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    a97bdb9 View commit details
    Browse the repository at this point in the history

  19. Move findPathInList from discoveryphase to common syncjournaldb 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    017dca2 View commit details
    Browse the repository at this point in the history

  20. Add specific message for existing folders exceeding warning limit in … 

    …accountsettings

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e05cf76 View commit details
    Browse the repository at this point in the history

  21. Remove redundant "optional" gui log functions which relly just call g… 

    …ui log under the hood

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    993ee6c View commit details
    Browse the repository at this point in the history

  22. Add methods to Folder so that other classes can easily add folder pat… 

    …hs to white/blacklists

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2bcefd6 View commit details
    Browse the repository at this point in the history

  23. Add convenience methods to folderman so that classes can add and remo… 

    …ve paths from folders without needing to know which folder the path belongs to

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7e17e92 View commit details
    Browse the repository at this point in the history

  24. Handle WHITELIST_FOLDER and BLACKLIST_FOLDER verbs in activitylistmodel 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    29cc9c0 View commit details
    Browse the repository at this point in the history

  25. Add method to get user pointer in UserModel by AccountState pointer 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    10989fa View commit details
    Browse the repository at this point in the history

  26. Add method to add notification activity in activity list in User 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e985367 View commit details
    Browse the repository at this point in the history

  27. Ensure whitelist/blacklist procedure removes activity 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    fe59d4e View commit details
    Browse the repository at this point in the history

  28. Create more than one converted activity link, therby respecting maxac… 

    …tionbuttons

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1293106 View commit details
    Browse the repository at this point in the history

  29. Do not create dismiss links for notifications as these are not used a… 

    …nyway

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    1 Configuration menu
    Copy the full SHA
    c975d40 View commit details
    Browse the repository at this point in the history

  30. Add activity for existing folder going over set limit 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    7d1fa16 View commit details
    Browse the repository at this point in the history

  31. Ensure newly whitelisted or blacklisted paths are removed from undeci… 

    …ded list

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5f250a5 View commit details
    Browse the repository at this point in the history

  32. Prevent double notification of folder now big in activities 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e2535d6 View commit details
    Browse the repository at this point in the history

  33. Prevent possible accountsettings crash by sorting blacklist before ch… 

    …ecking

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    f9bde98 View commit details
    Browse the repository at this point in the history

  34. Ensure folder whitelist and blacklist helper methods remove path from… 

    … other lists

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    6682b3a View commit details
    Browse the repository at this point in the history

  35. Default to adding existing now big folders to whitelist when undecided 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    a93279b View commit details
    Browse the repository at this point in the history

  36. Const autofy variables in ProcessDirectoryJob::processFile 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    74c4ec8 View commit details
    Browse the repository at this point in the history

  37. Constify SyncJournalDb::findPathInSelectiveSyncList 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1b73011 View commit details
    Browse the repository at this point in the history

  38. Remove use of old foreach in SyncJournalDb::setSelectiveSyncList 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    82f6fd5 View commit details
    Browse the repository at this point in the history

  39. Use simpler sort methods for white and black lists in discoveryphase 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    9fa5ae3 View commit details
    Browse the repository at this point in the history

  40. Fix trailing slash procedure in DiscoveryPhase::checkSelectiveSyncNew… 

    …Folder

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    ac8e9c4 View commit details
    Browse the repository at this point in the history

  41. Move trailingSlashPath convenience function into Utility class 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    3b208bf View commit details
    Browse the repository at this point in the history

  42. Replace all manual isntancesof adding trailing slash with use of util… 

    …ity method

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    21656cc View commit details
    Browse the repository at this point in the history

  43. Report size for directories in syncenginetestutils propfind response 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    4cdf525 View commit details
    Browse the repository at this point in the history

  44. Add test for correct reporting of existing folder overcoming size limit 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    0b13be6 View commit details
    Browse the repository at this point in the history

  45. Add config option to stop synchronising existing folders when they gr… 

    …ow beyond size

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    1342f81 View commit details
    Browse the repository at this point in the history

  46. Add UI element in general settings to stop syncing existing folders t… 

    …hat have now overcome limit

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    bd7ccf5 View commit details
    Browse the repository at this point in the history

  47. Stop current sync when existing folder becomes big and we have enable… 

    …d disabling sync of folders that become big

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    2324a60 View commit details
    Browse the repository at this point in the history

  48. Do not always re-notify user on existing folder now big if this folde… 

    …r already black or white listed

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    449bac8 View commit details
    Browse the repository at this point in the history

  49. Do not clear the whitelist on sync success 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    af45017 View commit details
    Browse the repository at this point in the history

  50. Ensure generated activity buttons are within count set by maxActionBu… 

    …ttons

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    9b5391b View commit details
    Browse the repository at this point in the history

  51. Fix generation of context menu activity links 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e987fe8 View commit details
    Browse the repository at this point in the history

  52. Fix breakages in testactivitylistmodel caused by recent activitylistm… 

    …odel changes

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    5db7926 View commit details
    Browse the repository at this point in the history

  53. Declare whitelist and blacklist activity verbs as static constexprs i… 

    …n activitydata, refer to this in usage

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    e1f342c View commit details
    Browse the repository at this point in the history

  54. Extract notifying of existing folder now big to separate static method 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    cbad434 View commit details
    Browse the repository at this point in the history

  55. Extract folder now big activity generation into separate method 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    a7fcb84 View commit details
    Browse the repository at this point in the history

  56. Deduplicate whitelistFolderPath and blacklistFolderPath 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    6d56621 View commit details
    Browse the repository at this point in the history

  57. Add additional logging for folder size check 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    a5d7c75 View commit details
    Browse the repository at this point in the history