Add option to notify when synced folder overcomes set size limit

[claucambra]

This expands upon the existing feature to not sync new folders larger than a set limit

Closes #5818

[mgallien]

@claucambra build is failing

[claucambra]

@claucambra build is failing

Now fixed

[github-actions]

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

[tobiasKaminsky]

@claucambra I gave this a test run

• enabled above option, limit to 50Mb
• create folder on server
• added 20kb
• synced
• added 54Mb
  --> file was downloaded without problems

It is shown here:

[claucambra]

@claucambra I gave this a test run

* enabled above option, limit to 50Mb

* create folder on server

* added 20kb

* synced

* added 54Mb
  --> file was downloaded without problems

It is shown here:

Great, working as expected then :) did you get the notification?

[tobiasKaminsky]

No, no notification.
And it should not sync folder, but first ask what to do, like in your first screenshot:

• client notices folder about limit
• client pauses sync for now
• client asks user what to do
• "keep syncing" -> resume sync
• "stop syncing" -> remove folder locally

[mgallien]

@claucambra please add automated tests covering teh changes in libsync code (mainly SyncEngine and related classes

[claucambra]

No, no notification. And it should not sync folder, but first ask what to do, like in your first screenshot:

* client notices folder about limit

* client pauses sync for now

* client asks user what to do

* "keep syncing" -> resume sync

* "stop syncing" -> remove folder locally

As far as I understood the task is to warn the user, not stop syncing the folder/stop the current sync run -- I imagine this would be annoying if sync suddenly stopped when folders grow, no?

Could you also send client logs for the sync run to debug the lack of a notification? Is there anything in the activity list? Thanks!

[tobiasKaminsky]

As the other options are also stated "ask for confirmation" I think we should do the same here.
I am sorry that I was not clear enough when writing description.

Once you have changed it, I can re-test and send debug archive if needed.

[claucambra]

As the other options are also stated "ask for confirmation" I think we should do the same here. I am sorry that I was not clear enough when writing description.

Once you have changed it, I can re-test and send debug archive if needed.

I have added an additional checkbox to disable synchronisation of files that have overcome limit now, feel free to test :)

[tobiasKaminsky]

Works great!
Ready for merge :-)

[codecov]

Codecov Report

Merging #5868 (fc45ef7) into master (8c65b06) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 79.16%.

❗ Current head fc45ef7 differs from pull request most recent head a5d7c75. Consider uploading reports for the commit a5d7c75 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5868      +/-   ##
==========================================
+ Coverage   60.06%   60.08%   +0.02%     
==========================================
  Files         145      145              
  Lines       18771    18797      +26     
==========================================
+ Hits        11275    11295      +20     
- Misses       7496     7502       +6     

Files Changed	Coverage Δ
src/common/syncjournaldb.h	75.00% <ø> (ø)
src/common/utility.h	0.00% <ø> (ø)
src/libsync/discovery.h	59.25% <ø> (ø)
src/libsync/discoveryphase.h	20.00% <ø> (ø)
src/libsync/logger.cpp	32.96% <ø> (+0.35%)	⬆️
src/libsync/logger.h	61.53% <ø> (ø)
src/libsync/syncengine.h	65.00% <ø> (ø)
src/libsync/theme.cpp	19.13% <0.00%> (+0.07%)	⬆️
src/libsync/configfile.cpp	27.08% <50.00%> (+0.76%)	⬆️
src/libsync/discovery.cpp	86.54% <76.74%> (+0.21%)	⬆️
... and 5 more

... and 1 file with indirect coverage changes

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
37 Code Smells

36.3% Coverage
0.0% Duplication

The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5868-a5d7c75e6f9e0e385b86780090c5c0c39e7bd54e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.