Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcActions): Use full window height #5809

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 16, 2024

Backport of #5806

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from Antreesy, ShGKme and susnux July 16, 2024 10:17
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: actions Related to the actions components labels Jul 16, 2024
@susnux susnux marked this pull request as ready for review July 22, 2024 12:42
@susnux susnux added this to the 9.0.0-alpha.6 milestone Jul 22, 2024
* Calculate the space on the window based on the trigger location.
* Respect boundaries element for popover height
* Assign NcContent as NcActions > NcPopover default boundaries

Co-authored-by: Maksim Sukharev <[email protected]>
Co-authored-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: actions Related to the actions components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant