fix(NcActions): Respect boundaries element for popover height

Signed-off-by: Ferdinand Thiessen <[email protected]> [skip ci]
nextcloud-libraries · Jul 16, 2024 · 8ae1a80 · 8ae1a80
1 parent 5dcab73
commit 8ae1a80
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/src/components/NcActions/NcActions.vue b/src/components/NcActions/NcActions.vue
@@ -1072,7 +1072,7 @@ export default {
 		 */
 		boundariesElement: {
 			type: Element,
-			default: () => document.querySelector('body'),
+			default: () => document.querySelector('#app-content-vue') ?? document.querySelector('body'),
 		},
 
 		/**
@@ -1361,6 +1361,8 @@ export default {
 					actionHeight = action.clientHeight
 					currentHeight += actionHeight
 				}
+			} else {
+				inner.style.height = 'fit-content'
 			}
 		},
 

diff --git a/styleguide.config.cjs b/styleguide.config.cjs
@@ -30,6 +30,7 @@ module.exports = async () => {
 			path.join(__dirname, 'styleguide/global.requires.js'),
 			path.join(__dirname, 'styleguide/assets/icons.css'),
 			path.join(__dirname, 'styleguide/assets/additional.css'),
+			path.join(__dirname, 'styleguide/assets/styleguide.css'),
 		],
 		pagePerSection: true,
 		minimize: true,

diff --git a/styleguide/assets/styleguide.css b/styleguide/assets/styleguide.css
@@ -0,0 +1,13 @@
+/*!
+ * SPDX-FileCopyrightText: 2017 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+#rsg-root {
+	height: 100%;
+}
+
+#rsg-root .rsg--root-1 {
+	height: 100%;
+	overflow: scroll;
+}