Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add configuration for adding labels to agent-forwarded logs. #19213

Closed

Conversation

jaffinito
Copy link
Member

@jaffinito jaffinito commented Nov 6, 2024

Give us some context

Updates the .NET Agent config doc to include configuration for the new feature adding labels to agent-forwarded logs.

Copy link

github-actions bot commented Nov 6, 2024

Hi @jaffinito 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 06ed9fb
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/673dc6cfab95d80008e989a2
😎 Deploy Preview https://deploy-preview-19213--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nbaenam nbaenam self-requested a review November 11, 2024 10:11
@nbaenam nbaenam self-assigned this Nov 11, 2024
@nbaenam nbaenam added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Nov 11, 2024
Copy link
Contributor

@nbaenam nbaenam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jaffinito, thank you for updating this! I did some style edits. Let me know what you think. Also, could you please sign the CLA by clicking the yellow button a few messages above this one? I'll be able to merge in as soon as you do. Thanks!

@jaffinito
Copy link
Member Author

jaffinito commented Nov 11, 2024

Edits look great!

I don't have a CLA button. I signed it a long time ago.

@nbaenam
Copy link
Contributor

nbaenam commented Nov 12, 2024

Edits look great!

I don't have a CLA button. I signed it a long time ago.

Hi @jaffinito, can you try this, please? https://cla-assistant.io/newrelic/docs-website?pullRequest=19213. We can't merge this PR without signing the CLA. It's a required check and it's not green. Maybe you need to re-sign it.

@jaffinito jaffinito marked this pull request as draft November 12, 2024 17:33
@jaffinito
Copy link
Member Author

jaffinito commented Nov 15, 2024

When I load that link, I see my details and it shows I agreed to it already:
image

Are you sure that check is working? I never had to do this with all my other PRs.

@jaffinito jaffinito marked this pull request as ready for review November 15, 2024 17:45
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ adutta-newrelic
❌ nbaenam


nbaenam seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@adutta-newrelic
Copy link
Contributor

Closing this PR as there is a conflict with the CLI, created a new #19341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants