-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add configuration for adding labels to agent-forwarded logs. #19213
chore: Add configuration for adding labels to agent-forwarded logs. #19213
Conversation
Hi @jaffinito 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jaffinito, thank you for updating this! I did some style edits. Let me know what you think. Also, could you please sign the CLA by clicking the yellow button a few messages above this one? I'll be able to merge in as soon as you do. Thanks!
Edits look great! I don't have a CLA button. I signed it a long time ago. |
Hi @jaffinito, can you try this, please? https://cla-assistant.io/newrelic/docs-website?pullRequest=19213. We can't merge this PR without signing the CLA. It's a required check and it's not green. Maybe you need to re-sign it. |
nbaenam seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Closing this PR as there is a conflict with the CLI, created a new #19341 |
Give us some context
Updates the .NET Agent config doc to include configuration for the new feature adding labels to agent-forwarded logs.