Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature: adding custom tags (labels) to APM agent-forwarded logs #19262

Merged
merged 7 commits into from
Nov 18, 2024

Conversation

Tcohn1
Copy link
Contributor

@Tcohn1 Tcohn1 commented Nov 11, 2024

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

this is a new feature that allows users to add custom tags(labels) to each individual log event as attributes. For more context see: https://newrelic.atlassian.net/wiki/spaces/~712020468958465767472dae555831f9e3cc31/pages/3678240795/APM+Agent+Logging+Include+APM+Custom+Tags+in+Logs+For+Better+Insights

PR: #19213

Copy link

Hi @Tcohn1 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 13e1e46
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/673ae0b4f7b09c0008b3fd8a
😎 Deploy Preview https://deploy-preview-19262--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rhetoric101 rhetoric101 self-assigned this Nov 12, 2024
@rhetoric101 rhetoric101 added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Nov 12, 2024
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the titles should be all the same case. so APM- should be apm- and Custom- should be custom-, no? cc @elucus

…APM-logs-custom-tags, and added the path in the logs.yaml file
Copy link
Contributor

@adutta-newrelic adutta-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have approved the changes and raising a merge request

@adutta-newrelic adutta-newrelic merged commit e214d04 into newrelic:develop Nov 18, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants