Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all fatal errors #2

Merged
merged 14 commits into from
Jan 7, 2025
Merged

Fix all fatal errors #2

merged 14 commits into from
Jan 7, 2025

Conversation

HDash
Copy link
Contributor

@HDash HDash commented Dec 4, 2024

Requires PR RajLabMSSM/echogithub#4 for echogithub to be accepted for full fix.

@HDash HDash added the bug Something isn't working label Dec 4, 2024
@HDash HDash requested a review from bschilder December 4, 2024 10:24
@HDash HDash self-assigned this Dec 4, 2024
@bschilder bschilder merged commit f36236c into master Jan 7, 2025
2 of 3 checks passed
@@ -0,0 +1,43 @@
#' @describeIn get_ get_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that adding this function here is actually not ideal, because it conflicts with the namespace in HPOExplorer.

1: replacing previous import ‘HPOExplorer::get_hpo’ by ‘KGExplorer::get_hpo’ when loading ‘MSTExplorer’ 

Instead, just use get_ontology("hpo") when trying to get the HPO within KGExplorer.

I'll apply this fix in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants