Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add single docker compose recipe for all deployment flavours #32

Merged
merged 26 commits into from
Apr 11, 2024
Merged

[ENH] Add single docker compose recipe for all deployment flavours #32

merged 26 commits into from
Apr 11, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Apr 9, 2024 •
edited
Loading

Changes proposed in this pull request:

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

rmanaem and others added 7 commits April 4, 2024 17:24
@rmanaem @alyssadai @surchs
Implemented new stuff
8e3dfb4 
Co-authored-by: Alyssa Dai <[email protected]>
Co-authored-by: Sebastian Urchs <[email protected]>
@rmanaem
Added template.env file
090e73c
@surchs
Added vocab file and renamed .env
508902d 
.env is ignored by default
@surchs
Wait specifically for the graphDB process ID
95db818
@surchs
Use Docker service name for local node
c94bf0b
@surchs
Add profiles
af42e5f 
- "dev" replaces the old behaviour
- other profile names replace the files in the other subdirectories
- start with `docker compose --profile <NAME> up`
@surchs
Make the local data directory configurable
83fae93
This was referenced Apr 9, 2024
Closed
Closed
alyssadai added 17 commits April 9, 2024 22:41
@alyssadai
upload vocab from separate directory + more progress messages
1143a4f
@alyssadai
remove non-template data-config.ttl (auto-created during setup)
30561d3
@alyssadai
add data-config.ttl to gitignore
205b186
@alyssadai
fix default value and mounting of data/
b5b9795
@alyssadai
replace hardcoded params inside setup.sh with env vars
b71cc6d
@alyssadai
update gitignore
f34d623
@alyssadai
set default profile in .env
59807cb
@alyssadai
update gitignore again
812ec5a
@alyssadai
write output of setup.sh to log
5cbc922
@alyssadai
Merge branch 'add-single-compose-config' of https://github.com/neurob…
0c0a8f3 
…agel/recipes into add-single-compose-config
@alyssadai
update .gitignore again :(
35a45d3
@alyssadai
switch query tool port to default used by Vite (#31)
2a93b40
@alyssadai
change log file name
9f4a89f
@alyssadai
bring back template configs
fa17229
@alyssadai
rename dev profile and update README
a7a2f39
@alyssadai
clean up README indentation
7f8fe7b
@alyssadai
mention log file
10ae958
@alyssadai alyssadai marked this pull request as ready for review April 10, 2024 21:15
@surchs surchs self-requested a review April 10, 2024 22:15
surchs
surchs approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! this looks great, works great, let's merge 🧑‍🍳

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
dev/data-config_template.ttl Show resolved Hide resolved
dev/setup.sh Outdated Show resolved Hide resolved
dev/template.env Outdated Show resolved Hide resolved
local_federation/docker-compose.yml Show resolved Hide resolved
@alyssadai alyssadai merged commit 546f3ee into main Apr 11, 2024
@alyssadai alyssadai deleted the add-single-compose-config branch April 11, 2024 15:03
@neurobagel-bot Neurobagel Bot
Copy link
Contributor

neurobagel-bot bot commented Aug 7, 2024

🚀 PR was released in v0.0.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to using one Compose recipe with multiple profiles/flavours Add local_nb_nodes.json to .gitignore
3 participants
@alyssadai @surchs @rmanaem