Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add single docker compose recipe for all deployment flavours #29

Closed
wants to merge 7 commits into from

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Apr 5, 2024

  • Closes #

Changes proposed in this pull request:

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

rmanaem and others added 7 commits April 4, 2024 17:24
Co-authored-by: Alyssa Dai <[email protected]>
Co-authored-by: Sebastian Urchs <[email protected]>
.env is ignored by default
- "dev" replaces the old behaviour
- other profile names replace the files in the other subdirectories
- start with `docker compose --profile <NAME> up`
@surchs
Copy link
Contributor Author

surchs commented Apr 9, 2024

@alyssadai was this an intentional close? I think the draft was pretty close to done, no?

@alyssadai
Copy link
Contributor

@surchs yes - I renamed the branch to something more informative so I will reopen the PR from the new branch. Probably there was a way to do that without closing this PR, sorry if it alarmed you 😅

@alyssadai
Copy link
Contributor

Replaced by #32

@surchs
Copy link
Contributor Author

surchs commented Apr 9, 2024

@surchs yes - I renamed the branch to something more informative so I will reopen the PR from the new branch. Probably there was a way to do that without closing this PR, sorry if it alarmed you 😅

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants