-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre release refactorization #16
Changes from all commits
a232fc2
a5acc73
520f0ef
e79361b
cb43efc
ac26383
a732063
68faf29
eed6ee7
3f8e568
666a9c6
972a362
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
name: Core Tests. | ||
|
||
on: | ||
push: | ||
branches: [master] | ||
pull_request: | ||
branches: [master] | ||
|
||
permissions: | ||
contents: read | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
- name: Set up Python 3.8.12 | ||
uses: actions/setup-python@v4 | ||
with: | ||
python-version: "3.8.12" | ||
- name: Install dependencies | ||
run: | | ||
pip install isort==5.10.1 black[jupyter]==22.3.0 | ||
- name: Run Black Format Check | ||
run: black . diff_rast/ tests/ examples/ --check |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
name: Docs | ||
on: | ||
push: | ||
branches: [main] | ||
pull_request: | ||
branches: [main] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. does this workflow work on PRs / branches? ( I guess similar question for the new nerfstudio docs workflow ) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It'll be triggered when there is PR or push to the main branch There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh i see your point -- if anyone wants to develop doc in a separate branch it won't be triggered. I feel like ppl should develop doc locally and only update gh-pages if it is ready to merge into main. |
||
workflow_dispatch: | ||
|
||
permissions: | ||
contents: write | ||
jobs: | ||
docs: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-python@v3 | ||
with: | ||
python-version: '3.9' | ||
- name: Install dependencies | ||
run: | | ||
pip install -r docs/requirements.txt | ||
pip install torch==2.0.0 --index-url https://download.pytorch.org/whl/cpu | ||
BUILD_NO_CUDA=1 pip install . | ||
- name: Sphinx build | ||
# fail on warnings: "-W --keep-going" | ||
run: | | ||
sphinx-build docs/source _build | ||
- name: Deploy | ||
uses: peaceiris/actions-gh-pages@v3 | ||
with: | ||
publish_branch: gh-pages | ||
github_token: ${{ secrets.GITHUB_TOKEN }} | ||
publish_dir: _build/ | ||
force_orphan: true | ||
# cname: ... |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -117,12 +117,6 @@ venv.bak/ | |
# line_profiler | ||
*.lprof | ||
|
||
# vscode | ||
.vsocde | ||
|
||
*build | ||
compile_commands.json | ||
|
||
*.png | ||
*.txt | ||
*.dump | ||
*.dump |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[submodule "csrc/third_party/glm"] | ||
path = csrc/third_party/glm | ||
url = https://github.com/g-truc/glm.git | ||
[submodule "diff_rast/cuda/csrc/third_party/glm"] | ||
path = diff_rast/cuda/csrc/third_party/glm | ||
url = https://github.com/g-truc/glm.git |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
recursive-include dir-pattern diff_rast/cuda/csrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isort seems unnecessary? for
black
versioning it might also make sense to just put in the package dependencies (probably as extras)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i forget to remove isort (i used to also check isort).
The black version is now in the [dev] dependencies in
setup.py