Pre release refactorization #16
Conversation
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| branches: [main] |
There was a problem hiding this comment.
does this workflow work on PRs / branches? ( I guess similar question for the new nerfstudio docs workflow )
There was a problem hiding this comment.
It'll be triggered when there is PR or push to the main branch
There was a problem hiding this comment.
Oh i see your point -- if anyone wants to develop doc in a separate branch it won't be triggered. I feel like ppl should develop doc locally and only update gh-pages if it is ready to merge into main.
| python-version: "3.8.12" | ||
| - name: Install dependencies | ||
| run: | | ||
| pip install isort==5.10.1 black[jupyter]==22.3.0 |
There was a problem hiding this comment.
this isort seems unnecessary? for black versioning it might also make sense to just put in the package dependencies (probably as extras)
There was a problem hiding this comment.
yeah i forget to remove isort (i used to also check isort).
The black version is now in the [dev] dependencies in setup.py
|
LGTM... although I know nothing about this docs stuff. I will go ahead and merge it and we can fix any issues with it later, thanks for saving the current main branch as well (that could be a useful reference in the future). |
Mainly move the cuda code into the
diff_rastfolder so that they will be packaged together with the python code.All executable codes are now under
examples.All debug & reference code have been removed.
Setup the workflow for auto format check (black) and auto doc generation (
gh-pagesbranch).The old main branch is move to branch
main_0928.