BUGFIX: Fix workspace role assignment after migration, import and site creation #5283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e creation With #5146 a basic workspace access control was implemented. With that, users won't have access to workspaces unless they have a role assigned. This can be achieved via ```shell ./flow workspace:assignrole ``` This bugfix makes sure, that the default behavior (users with the role `Neos.Neos:LivePublisher` can collaborate on the `live` workspace) is automatically ensured when creating/importing a site. Furthermore, the migration command has been fixed to add metadata & role assignments even if no workspace title was set: ```shell ./flow migrateevents:migrateWorkspaceMetadataToWorkspaceService ``` Related: #4726
mhsdesign
reviewed
Oct 11, 2024
Comment on lines
+122
to
+123
| $this->outputLine('Assigning live workspace role'); | ||
| $this->workspaceService->assignWorkspaceRole($contentRepositoryId, WorkspaceName::forLive(), WorkspaceRoleAssignment::createForGroup('Neos.Neos:LivePublisher', WorkspaceRole::COLLABORATOR)); |
There was a problem hiding this comment.
imo as hotfix we also should create a site entity for each imported site node here :)
There was a problem hiding this comment.
I'll take care of that in a follow-up
There was a problem hiding this comment.
also thie needs to be try catched, as a workspace role might already be assigned if you run this import before and then run cr:prune as the pruning would not prune the assignments ...
pKallert
requested changes
Oct 11, 2024
pKallert
approved these changes
Oct 11, 2024
mhsdesign
reviewed
Oct 11, 2024
Comment on lines
-516
to
-519
| if (!isset($eventData['workspaceTitle'])) { | ||
| // without the field it's not a legacy workspace creation event | ||
| continue 2; | ||
| } |
There was a problem hiding this comment.
without this statement
'Found %d legacy workspace events resulting in %d workspaces.
is wrong. .. also this is okay not to be there? We have runtime migration fallback? Why did we remove this check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #5146 a basic workspace access control was implemented. With that, users won't have access to workspaces unless they have a role assigned.
This can be achieved via
This bugfix makes sure, that the default behavior (users with the role
Neos.Neos:LivePublishercan collaborate on theliveworkspace) is automatically ensured when creating/importing a site.Furthermore, the migration command has been fixed to add metadata & role assignments even if no workspace title was set:
Related: #4726