BUGFIX: Fix admin workspace permissions for workspaces without metadata #5290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes sure that metadata exists for the `live` workspace after running the `cr:import` command. Furthermore it fixes the permission determiniation for administrators in case no metadata is specified for a workspace but the role assignment exists Related: #4726
|
Thanks for the pr, maybe we can also address my post merge comments of #5283 here;) |
mhsdesign
reviewed
Oct 16, 2024
mhsdesign
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that metadata exists for the
liveworkspace after running thecr:importcommand. Furthermore it fixes the permission determiniation for administrators in case no metadata is specified for a workspace but the role assignment existsRelated: #4726
Followup to #5283