[1.20.x] Fix Reach Issues (and eclipse compilation issues) #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technici4n
previously requested changes
Dec 9, 2023
|
Like it or not, we support eclipse, so we have to be compatible with the eclipse compiler. |
Shadows-of-Fire
force-pushed
the
reach-fix
branch
from
96d346d
to
669f13b
Compare
|
At some point, we ought to add some automated check to compile with the Eclipse compiler. Though that may be somewhat difficult, given how hardcoded Gradle seems to be with using a |
Shadows-of-Fire
force-pushed
the
reach-fix
branch
from
cbec310
to
367b271
Compare
Shadows-of-Fire
changed the title
Technici4n
reviewed
Dec 12, 2023
src/main/java/net/neoforged/neoforge/common/extensions/IPlayerExtension.java
Show resolved
Hide resolved
Technici4n
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #243 and other reach changes that should have been fixed in porting. It also fixes issues with the eclipse compiler that were introduced by #73