-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.21.3] Render Minecraft logo as builtin mods logoFile
#1617
Conversation
Last commit published: 86fa3ac69f08bd0bd53cac6560ab4656b909f8bc. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1617' // https://github.com/neoforged/NeoForge/pull/1617
url 'https://prmaven.neoforged.net/NeoForge/pr1617'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1617
cd NeoForge-pr1617
curl -L https://prmaven.neoforged.net/NeoForge/pr1617/net/neoforged/neoforge/21.3.4-beta-pr-1617-pr-mc-logo/mdk-pr1617.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
The way this is implemented I do not have access to the positional data, only the width/height which is using constants from That being said what you provided doesnt look moved necessarily, just larger in size, might I ask how large yours is? |
928cab5
to
86fa3ac
Compare
Rebased to include #1615 rather than needing to be manually applied locally |
🚀 This PR has been released as NeoForge version |
Redirects mod container
logoFile
generation/rendering to simply render the built in vanilla logo png file when viewing the built in Minecraft mod info.Fixes #1616 depends on #1615
Before
After