Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mod logos not being rendered in the mod list #1615

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

Matyrobbrt
Copy link
Member

Seems like the UVs and the dimensions were swapped in the blit call.
Fixes #1611

Seems like the UVs and the dimensions were swapped in the `blit` call.
Fixes neoforged#1611
@Matyrobbrt Matyrobbrt added bug A bug or error rendering Related to rendering 1.21.2 Targeted at Minecraft 1.21.2 labels Oct 23, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Oct 23, 2024

  • Publish PR to GitHub Packages

Last commit published: ef7d4775df3d8e0e87a5a9ae81bef235237380d1.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1615' // https://github.com/neoforged/NeoForge/pull/1615
        url 'https://prmaven.neoforged.net/NeoForge/pr1615'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1615.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1615
cd NeoForge-pr1615
curl -L https://prmaven.neoforged.net/NeoForge/pr1615/net/neoforged/neoforge/21.3.2-beta-pr-1615-gh-1611/mdk-pr1615.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

Copy link
Contributor

@ApexModder ApexModder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked while testing minecraft logo rendering in #1617

@Matyrobbrt Matyrobbrt added 1.21.3 Targeted at Minecraft 1.21.3 and removed 1.21.2 Targeted at Minecraft 1.21.2 labels Oct 23, 2024
@Matyrobbrt Matyrobbrt merged commit 3f10254 into neoforged:1.21.x Oct 24, 2024
7 checks passed
@Matyrobbrt Matyrobbrt deleted the gh-1611 branch October 24, 2024 15:58
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.3.2-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error rendering Related to rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.21.2] NeoForge logo not rendered in mods list
2 participants