Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fsdk,Fsdk.Tests: enable Misc/Tsv tests on legacy #36

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Fsdk,Fsdk.Tests: enable Misc/Tsv tests on legacy #36

merged 2 commits into from
Aug 23, 2023

Commits on Aug 23, 2023

  1. Fsdk.Tests: include TSV in legacy proj 

    It was only tested in non-legacy (dotnet v6 or newer).
    @knocte
    knocte committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    f6287f7 View commit details
    Browse the repository at this point in the history

  2. Fsdk/Misc: fix NRE if legacy 

    When running TSV unit tests in legacy framework (e.g. Mono),
a NRE was being thrown; I guess because in that case the
function GetEntryAssembly() was returning null.

This fix is kinda ugly but is anyway affecting a part of the
code that I plan to retire soon (cause it's API wrapped under
LEGACY_FRAMEWORK ifdef).
    @knocte
    knocte committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7a4b950 View commit details
    Browse the repository at this point in the history