Fsdk,Fsdk.Tests: enable Misc/Tsv tests on legacy #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was only tested in non-legacy (dotnet v6 or newer).
When running TSV unit tests in legacy framework (e.g. Mono), a NRE was being thrown; I guess because in that case the function GetEntryAssembly() was returning null. This fix is kinda ugly but is anyway affecting a part of the code that I plan to retire soon (cause it's API wrapped under LEGACY_FRAMEWORK ifdef).
knocte
force-pushed
the
wip/testMiscOnLegacy
branch
2 times, most recently
from
88a9a9e
to
7a4b950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.