Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from dotnet7 to dotnet8 #18

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Move from dotnet7 to dotnet8 #18

merged 5 commits into from
Feb 5, 2024

Commits on Feb 5, 2024

  1. CI: move from dotnet7 to dotnet8 

    The Directory.Build.targets old workaround is removed
as well because it's not needed in dotnet8 anymore.
    @knocte
    knocte committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    82f1f64 View commit details
    Browse the repository at this point in the history

  2. FX.Tests: add FSharp.Core ref to fix build 

    To try to fix this build error:

```
/__w/FX/FX/src/FX.Tests/LimitOrders.cs(5,17): error CS0234: The type or namespace name 'FSharp' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?)
[/__w/FX/FX/src/FX.Tests/FX.Tests.csproj]
/__w/FX/FX/src/FX.Tests/LimitOrders.cs(16,25): error CS0246: The type or namespace name 'FSharpOption<>' could not be found (are you missing a using directive or an assembly reference?)
[/__w/FX/FX/src/FX.Tests/FX.Tests.csproj]
    7 Warning(s)
    2 Error(s)
```
    @knocte
    knocte committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    cf7daf5 View commit details
    Browse the repository at this point in the history

  3. FX.Tests: add version to FSharp.Core ref to fix restore 

    To try to fix this restore error:
```
/__w/FX/FX/src/FX.Tests/FX.Tests.csproj : error NU1010: The PackageReference items FSharp.Core do not have corresponding PackageVersion. [/__w/FX/FX/FX.sln]
  Failed to restore /__w/FX/FX/src/FX.Tests/FX.Tests.csproj (in 451 ms).
```
    @knocte
    knocte committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a4ee0e9 View commit details
    Browse the repository at this point in the history

  4. Directory.Packages.props,FX.Tests: move version attrib out of proj 

    In order to fix this restore error:
```
/__w/FX/FX/src/FX.Tests/FX.Tests.csproj : error NU1008: Projects that use
central package version management should not define the version on the
PackageReference items but on the PackageVersion items: FSharp.Core.
[/__w/FX/FX/FX.sln]
```
    @knocte
    knocte committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    1496cdc View commit details
    Browse the repository at this point in the history

  5. FX.Tests: move from net7.0 to net8.0 

    To fix this error when trying to run the tests:
```
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
Testhost process for source(s) '/__w/FX/FX/src/FX.Tests/bin/Debug/net7.0/FX.Tests.dll' exited with error: You must install or update .NET to run this application.
App: /__w/FX/FX/src/FX.Tests/bin/Debug/net7.0/testhost.dll
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '7.0.0' (x64)
.NET location: /usr/lib/dotnet/
The following frameworks were found:
  8.0.1 at [/usr/lib/dotnet/shared/Microsoft.NETCore.App]
Learn more:
https://aka.ms/dotnet/app-launch-failed
To install missing framework, download:
https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=7.0.0&arch=x64&rid=ubuntu.23.10-x64&os=ubuntu.23.10
. Please check the diagnostic logs for more information.

Test Run Aborted.
```
    @knocte
    knocte committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    0205671 View commit details
    Browse the repository at this point in the history