Move from dotnet7 to dotnet8 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Directory.Build.targets old workaround is removed as well because it's not needed in dotnet8 anymore.
To try to fix this build error:
```
/__w/FX/FX/src/FX.Tests/LimitOrders.cs(5,17): error CS0234: The type or namespace name 'FSharp' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?)
[/__w/FX/FX/src/FX.Tests/FX.Tests.csproj]
/__w/FX/FX/src/FX.Tests/LimitOrders.cs(16,25): error CS0246: The type or namespace name 'FSharpOption<>' could not be found (are you missing a using directive or an assembly reference?)
[/__w/FX/FX/src/FX.Tests/FX.Tests.csproj]
7 Warning(s)
2 Error(s)
```
To try to fix this restore error: ``` /__w/FX/FX/src/FX.Tests/FX.Tests.csproj : error NU1010: The PackageReference items FSharp.Core do not have corresponding PackageVersion. [/__w/FX/FX/FX.sln] Failed to restore /__w/FX/FX/src/FX.Tests/FX.Tests.csproj (in 451 ms). ```
In order to fix this restore error: ``` /__w/FX/FX/src/FX.Tests/FX.Tests.csproj : error NU1008: Projects that use central package version management should not define the version on the PackageReference items but on the PackageVersion items: FSharp.Core. [/__w/FX/FX/FX.sln] ```
To fix this error when trying to run the tests: ``` Starting test execution, please wait... A total of 1 test files matched the specified pattern. Testhost process for source(s) '/__w/FX/FX/src/FX.Tests/bin/Debug/net7.0/FX.Tests.dll' exited with error: You must install or update .NET to run this application. App: /__w/FX/FX/src/FX.Tests/bin/Debug/net7.0/testhost.dll Architecture: x64 Framework: 'Microsoft.NETCore.App', version '7.0.0' (x64) .NET location: /usr/lib/dotnet/ The following frameworks were found: 8.0.1 at [/usr/lib/dotnet/shared/Microsoft.NETCore.App] Learn more: https://aka.ms/dotnet/app-launch-failed To install missing framework, download: https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=7.0.0&arch=x64&rid=ubuntu.23.10-x64&os=ubuntu.23.10 . Please check the diagnostic logs for more information. Test Run Aborted. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #17