Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves 38 issue #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolves 38 issue #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 35 additions & 8 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,22 @@
<html>
<head>
<title>Document Two Sections</title>
<link rel="stylesheet" href="style.css">
<link rel="stylesheet" href="style.css" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add / here. Can you remove it?

Suggested change
<link rel="stylesheet" href="style.css" />
<link rel="stylesheet" href="style.css">

</head>

<body>
<h1>Excepteur Sint Occaecat</h1>
<p id="paragraph1">Lorem ipsum <strong>dolor</strong> sit <em>amet</em>, <b>consectetur</b> adipiscing <i>elit</i>. Duis condimentum sagittis ex</p>
<p id="paragraph1">
Lorem ipsum
<strong>dolor</strong>
sit
<em>amet</em>
,
<b>consectetur</b>
adipiscing
<i>elit</i>
. Duis condimentum sagittis ex
</p>
<ul class="list">
<li class="">
<a href="#">first point</a>
Expand All @@ -15,20 +26,36 @@ <h1>Excepteur Sint Occaecat</h1>
<a href="#">second point</a>
</li>
<li class="">
<a href="#"> <!-- use .list-item-link class if you are confused about nested selectors -->
<a href="#">
<!-- use .list-item-link class if you are confused about nested selectors -->
third point
</a>
</li>
</ul>
<h2 class="highlight point">Duis Aute</h2>
<p>Quis nostrud exercitation ullamco <a href="https://yahoo.com" target="_blank">laboris</a> nisi ut aliquip ex ea commodo consequat.</p>
<img src="https://www.rd.com/wp-content/uploads/2016/01/04-dog-breeds-dalmation.jpg" width="150" alt="a Dalmatian dog">
<audio src="https://github.com/nbktechworld/introduction-to-html/raw/abcdac58651ba724c40665c82dd55f171534115f/document-two-sections/barking.mp3" controls></audio>
<ol>
<p>
Quis nostrud exercitation ullamco
<a href="https://yahoo.com" target="_blank">laboris</a>
nisi ut aliquip ex ea commodo consequat.
</p>
<img
src="https://www.rd.com/wp-content/uploads/2016/01/04-dog-breeds-dalmation.jpg"
width="150"
alt="a Dalmatian dog"
/>
<audio
src="https://github.com/nbktechworld/introduction-to-html/raw/abcdac58651ba724c40665c82dd55f171534115f/document-two-sections/barking.mp3"
controls
></audio>
<ol class="order">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you added the class order here. Did you forget to commit the definition of that class?

<li>first point</li>
<li>second point</li>
<li>third point</li>
</ol>
<video src="http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4" controls width="300"></video>
<video
Copy link
Member

@nbkhope nbkhope Jun 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to not change code unrelated to the issue at hand.

You should focus on the issue and what it's asking. If the issue doesnt require a code change here, you shouldnt be changing it. Even if you think the style is prettier the way you write here. You should strive to do the least amount of work as possible and avoid "diff noise" by changing unrelated code just because you feel a certain way about how it looks.

Update: I think you might be using an automatic code formatter. Maybe dont use it.

src="http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4"
controls
width="300"
></video>
</body>
</html>