Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves 38 issue #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

metaversemoon
Copy link

Resolves 38 issue

@nbkhope
Copy link
Member

nbkhope commented Jun 20, 2024

@metaversemoon try adding a # before the issue number so it can be linked.
In your pull request description, it should read:

Resolves #38

@@ -2,11 +2,22 @@
<html>
<head>
<title>Document Two Sections</title>
<link rel="stylesheet" href="style.css">
<link rel="stylesheet" href="style.css" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add / here. Can you remove it?

Suggested change
<link rel="stylesheet" href="style.css" />
<link rel="stylesheet" href="style.css">

<li>first point</li>
<li>second point</li>
<li>third point</li>
</ol>
<video src="http://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4" controls width="300"></video>
<video
Copy link
Member

@nbkhope nbkhope Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to not change code unrelated to the issue at hand.

You should focus on the issue and what it's asking. If the issue doesnt require a code change here, you shouldnt be changing it. Even if you think the style is prettier the way you write here. You should strive to do the least amount of work as possible and avoid "diff noise" by changing unrelated code just because you feel a certain way about how it looks.

Update: I think you might be using an automatic code formatter. Maybe dont use it.

src="https://github.com/nbktechworld/introduction-to-html/raw/abcdac58651ba724c40665c82dd55f171534115f/document-two-sections/barking.mp3"
controls
></audio>
<ol class="order">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you added the class order here. Did you forget to commit the definition of that class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants