Add e2e tests #694
Merged
Add e2e tests #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylew1
commented
Jul 17, 2024
lorenyu
reviewed
Jul 18, 2024
lorenyu
reviewed
Jul 22, 2024
Co-authored-by: Loren Yu <[email protected]>
|
We've accumulated quite a few changes, do we want to apply these changes back to |
rylew1
commented
Jul 22, 2024
@rylew1 yeah definitely. I kind of assumed you were testing the changes, so yeah if you haven't yet then let's do one last final test to make sure it all works |
|
Sorry accidentally closed the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves navapbc/template-application-nextjs#358
Changes
Context
Original working PR on nextjs test repo => [Issue #358]: Add e2e tests against PR preview env platform-test-nextjs#85
Since we update the PR on this
template-infrarepo, I checked that it still runs successfully onplatform-test-nextjshere: [Demo]: Updated e2e tests with changes from template-infra platform-test-nextjs#86The docs PR check error I don't think will resolve until this is merged