-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #358]: Add e2e tests against PR preview env #85
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing. So excited to have e2e tests!
roll capture service endpoint into update environment step Co-authored-by: Loren Yu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in .github/workflows/ci-app-pr-environment-update.yml, rename the workflow from "CI App PR Environment Update" to "CI App PR Environment Checks" and rename the file to .github/workflows/ci-app-pr-environment-checks.yml
.github/workflows/e2e-tests.yml
Outdated
- name: Set up Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: '20' | ||
|
||
- name: Install system dependencies | ||
run: | | ||
sudo apt-get update | ||
sudo apt-get install -y libwoff1 libopus0 libvpx7 libevent-2.1-7 libopus0 libgstreamer1.0-0 \ | ||
libgstreamer-plugins-base1.0-0 libgstreamer-plugins-good1.0-0 libharfbuzz-icu0 libhyphen0 \ | ||
libenchant-2-2 libflite1 libgles2 libx264-dev | ||
|
||
- name: Install Node.js dependencies | ||
run: npm ci | ||
working-directory: ./e2e | ||
|
||
- name: Install Playwright browsers | ||
run: npx playwright install --with-deps | ||
working-directory: ./e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.. there are a lot more dependencies here than I expected. Installing linux packages, node libraries, and browsers. Given how much there is here we should containerize this and run it all in a container, like we do with unit tests. Makes me think that we should consider Dockerizing this like we do for unit tests in the Flask template. Does Playwright run ok in a Docker container?
cc @rocketnova what do you think?
That said I'd be open to doing that in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would vote separate pr as this is getting large
sudo apt-get update | ||
sudo apt-get install -y libwoff1 libopus0 libvpx7 libevent-2.1-7 libopus0 libgstreamer1.0-0 \ | ||
libgstreamer-plugins-base1.0-0 libgstreamer-plugins-good1.0-0 libharfbuzz-icu0 libhyphen0 \ | ||
libenchant-2-2 libflite1 libgles2 libx264-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these for? Does it merit a comment or link to documentation that explains the need for these packages and/or what they do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it helps, you can see the initial deps failure here: https://github.com/navapbc/platform-test-nextjs/actions/runs/9885358319/job/27303354260
Co-authored-by: Loren Yu <[email protected]>
…navapbc/platform-test-nextjs into rylew/358-e2e-tests-preview-env
Moved over to template-infra repo navapbc/template-infra#694 |
Ticket
Resolves #358
Changes
Context
template-infra
[Demo]: Updated e2e tests with changes from template-infra #86template-infra
PR to be merged: Add e2e tests template-infra#694Preview environment