41 port cvp mesh planner pkg to ros2 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reformulate the README introduction
add usage section, wip.
mrvsht
reviewed
Jan 30, 2024
| virtual uint32_t makePlan(const geometry_msgs::msg::PoseStamped& start, | ||
| const geometry_msgs::msg::PoseStamped& goal, | ||
| double tolerance, | ||
| std::vector<geometry_msgs::msg::PoseStamped>& plan, double& cost, |
There was a problem hiding this comment.
you have formatted each variable in a line, but not cost
mrvsht
reviewed
Jan 30, 2024
| double cost_limit = 1.0; | ||
| //! The vector field back tracking step width. | ||
| double step_width = 0.4; | ||
| } config_; |
There was a problem hiding this comment.
I did this with member variables in the ftc_controller.
But i like this option, to use a struct member variable with all config options.
Maybe we can change it inside the ftc_controller and use this option for all mbf_plugins
mrvsht
approved these changes
Jan 30, 2024
Base automatically changed from
40-port-dijkstra_mesh_planner-pkg-to-ros2
to
humble
January 30, 2024 10:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the cvp mesh planner pkg to ROS2 and fixes #41.
It also contains commits with changes to the README from
master, which are inconsequential to #41. But it doesn't hurt to get these commits to the humble branch as well.Based on #44, so best review PR44 first.