Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMT-3561: Adding Pagination to Table Component #1110
MMT-3561: Adding Pagination to Table Component #1110
Changes from 10 commits
b89cbb1
10d76a5
205f9cc
9f15d69
6a6405f
4a3f8db
3de9b6d
4a6d7ac
e003d4a
bd18c78
0a2ba21
94fc6af
3fa0aec
3a1d179
abba026
606cf0d
d8de076
bcef541
368a920
9825156
7feb925
c059d73
9fb74c9
607d34b
23b301b
8cad2e6
66ce18e
5190f2f
17c78c5
a57b864
e0b8e6e
a6e54e2
868cbae
ac94889
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coverage is saying this line is uncovered in your tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this class is getting pretty long, wonder if it would be better to pull it out into a separate component? Just the pagination piece.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! I had a comment about breaking it up.