MMT-3561: Adding Pagination to Table Component #1110
Conversation
| returnItems.push( | ||
| <Pagination.Item | ||
| key="page-1" | ||
| onClick={() => handleItemClick(1)} |
There was a problem hiding this comment.
coverage is saying this line is uncovered in your tests
| returnItems.push( | ||
| <Pagination.Item | ||
| key={`page-${lastPageNum}`} | ||
| onClick={() => handleItemClick(lastPageNum)} |
| setCurrentCount(newCurrentCount) | ||
| } | ||
|
|
||
| const pagination = ( |
There was a problem hiding this comment.
I feel like this class is getting pretty long, wonder if it would be better to pull it out into a separate component? Just the pagination piece.
There was a problem hiding this comment.
Agreed! I had a comment about breaking it up.
| setCurrentCount(newCurrentCount) | ||
| } | ||
|
|
||
| const pagination = ( |
There was a problem hiding this comment.
Agreed! I had a comment about breaking it up.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## MMT-3390 #1110 +/- ##
============================================
+ Coverage 96.85% 96.95% +0.09%
============================================
Files 170 172 +2
Lines 2096 2164 +68
Branches 421 431 +10
============================================
+ Hits 2030 2098 +68
Misses 66 66 ☔ View full report in Codecov by Sentry. |
| } = item | ||
| const { | ||
| ShortName, EntryTitle, Name, LongName |
There was a problem hiding this comment.
These should be separate lines. Not sure why eslint didnt complain here 🤔
No description provided.