Vindigo cumulus 3184 #1124
Open
Vindigo cumulus 3184 #1124
+15,949
−8,218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Jkovarik
commented
Feb 15, 2024
| @@ -25,13 +25,14 @@ const ExecutionStatusGraph = ({ executionStatus }) => { | |||
| const workflow = JSON.parse(stateMachine.definition); | |||
| const events = getExecutionEvents(executionHistory); | |||
| const graph = workflowToGraph(workflow); | |||
| console.log('graph', graph); | |||
There was a problem hiding this comment.
This looks like it should be removed.
jjmccoy
added
PR Feedback
Needs Review
4 tasks
npauzenga
requested changes
Feb 21, 2024
package.json
Outdated
| @@ -149,11 +149,10 @@ | |||
| "compare-versions": "^4.1.2", | |||
| "connected-react-router": "^6.9.2", | |||
| "console-browserify": "^1.2.0", | |||
| "core-js": "^3.20.1", | |||
| "core-js": "^3.35.1", | |||
There was a problem hiding this comment.
Was this also due to the dagre update or a separate concern? Fine either way, just clarifying.
There was a problem hiding this comment.
Change was to avoid conflict with develop.
There was a problem hiding this comment.
Like a merge conflict? It's probably fine to update a package like this but what was the conflict?
package.json
Outdated
| @@ -171,7 +170,7 @@ | |||
| "path-browserify": "^1.0.1", | |||
| "postcss": "^8.4.5", | |||
| "process": "^0.11.10", | |||
| "prop-types": "^15.8.0", | |||
| "prop-types": "^15.8.1", | |||
There was a problem hiding this comment.
Same question. Was this a vulnerability?
There was a problem hiding this comment.
Change was to avoid conflict with develop.
Changed git+ssh to git+https in package-lock file
boom audit error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling in #1123
Summary: Summary of changes
Addresses CUMULUS-3184: Dependency d3-dag code integration to d3 graph
Changes
dagre-d3withdagre-d3-esto address thed3-colorvulnerabilityd3tov7.2.0to be compatible withdagre-d3-esv7.0.10PR Checklist