Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cumulus 3184 : Dependency d3-dag code integration to d3 graph #1123

Closed
wants to merge 6 commits into from

Conversation

vindigo
Copy link
Contributor

@vindigo vindigo commented Feb 9, 2024

Summary: Summary of changes

Addresses CUMULUS-3184: Dependency d3-dag code integration to d3 graph

Changes

  • Replaced dagre-d3 with dagre-d3-es to address the d3-color vulnerability
  • Upgraded d3 to v7.2.0 to be compatible with dagre-d3-es v7.0.10

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Adhoc testing
  • Integration tests

@vindigo vindigo marked this pull request as ready for review February 13, 2024 17:41
@jjmccoy jjmccoy added Needs Review Looking for a reviewer and removed Work In Progress labels Feb 14, 2024
@@ -25,13 +25,14 @@ const ExecutionStatusGraph = ({ executionStatus }) => {
const workflow = JSON.parse(stateMachine.definition);
const events = getExecutionEvents(executionHistory);
const graph = workflowToGraph(workflow);
console.log('graph', graph);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed?

@Jkovarik Jkovarik mentioned this pull request Feb 15, 2024
4 tasks
@Jkovarik
Copy link
Member

Closing in favor of #1124

@Jkovarik Jkovarik closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Looking for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants