Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse map multiple cameras #804

Open
wants to merge 53 commits into
base: develop
Choose a base branch
from

Conversation

rsoussan
Copy link
Member

Add support for using multiple cameras when making sparse maps. Updated localization node to localize with the camera params from the current robot config.
@amoravargas

rsoussan and others added 30 commits June 29, 2024 10:45
@rsoussan rsoussan changed the base branch from master to develop July 30, 2024 00:02
@rsoussan rsoussan closed this Jul 30, 2024
@rsoussan rsoussan reopened this Jul 30, 2024
Copy link
Member

@bcoltin bcoltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you tested with both new and previous maps. Impressed you managed to finish this in time, great work!

@rsoussan
Copy link
Member Author

Assuming you tested with both new and previous maps. Impressed you managed to finish this in time, great work!

Thanks! Yeah I tested map creation with different camera models, including merging, and localizing on maps old and new. Looks good, we might want to have @amoravargas test it with a real mapping pipeline before we merge, also haven't done granite tests

@bcoltin
Copy link
Member

bcoltin commented Jul 31, 2024

Make sure to fix the CI too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants