Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups #78

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Cleanups #78

wants to merge 8 commits into from

Commits on Aug 4, 2019

  1. Drop unused imports

    ukleinek committed Aug 4, 2019
    Configuration menu
    Copy the full SHA
    23694ee View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2019

  1. Make compatible with python3

    Only adaptions to print statments were needed
    ukleinek committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    bb49109 View commit details
    Browse the repository at this point in the history
  2. Remove trailing whitespace

    ukleinek committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    d6f7ffe View commit details
    Browse the repository at this point in the history
  3. MFRC522: drop unnecessary ; at line ends

    They are not needed and to use them is unpythonic
    ukleinek committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    4eba92f View commit details
    Browse the repository at this point in the history
  4. MFRC522: convert DOS to UNIX line endings

    MFRC522.py was the only file in this project with DOS line endings
    ukleinek committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    03b7d05 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2019

  1. MFRC522: fold MFRC522_Init into its only caller

    MFRC522_Init is only ever called from MFRC522's __init__ function. Move all
    of the former into the latter function dropping a duplicate call to
    GPIO.output(self.NRSTPD, 1).
    ukleinek committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    2901e51 View commit details
    Browse the repository at this point in the history
  2. MFRC522: improve RPi.GPIO usage

    Instead of letting the users of an MFRC522 instance clean up the resources
    of RPi.GPIO, do this in the __del__ method of the instance. Also only clean
    up the channel used as a complete cleanup might interfere with other parts
    of a program that uses RPi.GPIO also for other stuff.
    ukleinek committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    472c8b2 View commit details
    Browse the repository at this point in the history
  3. MFRC522: pass initial value for output GPIO

    Depending on the state of the GPIO used for NRSTPD calling
    
    	GPIO.setup(self.NRSTPD, GPIO.OUT)
    
    might drive the line to its low level until
    
    	GPIO.output(self.NRSTPD, 1)
    
    is called. To prevent this spike combine these two calls into a single call
    to setup specifying an initial value.
    ukleinek committed Oct 7, 2019
    Configuration menu
    Copy the full SHA
    b22cae3 View commit details
    Browse the repository at this point in the history