Cleanups #78
Open
Cleanups #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only adaptions to print statments were needed
They are not needed and to use them is unpythonic
MFRC522.py was the only file in this project with DOS line endings
MFRC522_Init is only ever called from MFRC522's __init__ function. Move all of the former into the latter function dropping a duplicate call to GPIO.output(self.NRSTPD, 1).
Instead of letting the users of an MFRC522 instance clean up the resources of RPi.GPIO, do this in the __del__ method of the instance. Also only clean up the channel used as a complete cleanup might interfere with other parts of a program that uses RPi.GPIO also for other stuff.
Depending on the state of the GPIO used for NRSTPD calling GPIO.setup(self.NRSTPD, GPIO.OUT) might drive the line to its low level until GPIO.output(self.NRSTPD, 1) is called. To prevent this spike combine these two calls into a single call to setup specifying an initial value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to make use of this project on a non-rpi hardware with python3. These are the cleanups I applied for it.
I didn't include the bits to make it run on my platform as this probably breaks on rpi then :-)