Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicator positioning fix V2. #317

Merged

Conversation

amin-xiv
Copy link
Contributor

@amin-xiv amin-xiv commented Nov 6, 2024

Description

I fixed the positioning of the theme indicator. This is version 2, I couldn't update the last pull request due to some problems with that branch.

Related Issue

Fixes #302

Type of change

  • Bug fix
  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

indicatorPositioningFix

Copy link
Contributor

github-actions bot commented Nov 6, 2024

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit 770f220
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/672bd6cf3ccf1400081a3b53
😎 Deploy Preview https://deploy-preview-317--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amin-xiv
Copy link
Contributor Author

amin-xiv commented Nov 6, 2024

Here it is @multiverseweb, I have already done it. Share your thoughts

@multiverseweb
Copy link
Owner

Looks good to me, merging👍

@multiverseweb multiverseweb merged commit b483be7 into multiverseweb:main Nov 6, 2024
6 checks passed
Copy link
Contributor

github-actions bot commented Nov 6, 2024

🎉🎉 Thank you for your contribution! Your PR #317 has been merged! 🎉🎉

@amin-xiv amin-xiv deleted the indicator-positioning-fix-v2 branch November 6, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Website] Fix the theme button
2 participants