Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed indicator positioning when opening the burger menu #310

Closed

Conversation

amin-xiv
Copy link
Contributor

@amin-xiv amin-xiv commented Nov 6, 2024

… menu.

Description

Fixed the indicator of the current theme, not positioning properly when opening the burger menu.

Related Issue

Fixes #302

Type of change

  • Bug fix
  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

github-actions bot commented Nov 6, 2024

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit ed85ef1
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/672bd41aa94beb0008934ddd
😎 Deploy Preview https://deploy-preview-310--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jency1
Copy link
Collaborator

jency1 commented Nov 6, 2024

@amin-xiv The issue was of fixing the position of the indicator div, which is still not fixed for the third button. So fix it.

And get the issue assigned first for getting the PR merged. Just drop the comment in the issue for getting the issue assigned.

@amin-xiv
Copy link
Contributor Author

amin-xiv commented Nov 6, 2024

@jency1 Hi, I made the new changes in an another PR since I had some problems with this branch, it is PR #317 .
Thank you.

@amin-xiv amin-xiv closed this Nov 6, 2024
@amin-xiv amin-xiv deleted the indicator-positioning-fix branch November 7, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Website] Fix the theme button
2 participants