-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[l10n] Add Arabic (ar) locale #15693
base: master
Are you sure you want to change the base?
Conversation
Localization writing tips ✍️Seems you are updating localization 🌍 files. Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️
Deploy preview: https://deploy-preview-15693--material-ui-x.netlify.app/ |
@@ -36,4 +36,5 @@ export * from './urPK'; | |||
export * from './viVN'; | |||
export * from './zhCN'; | |||
export * from './zhHK'; | |||
export * from './ar'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on other languages, it is recommended to specify the country of the language, such as arMR or arEG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ET-TOUNANI As arabic is spoken in many countries they have many dialects just like eu. So i have taken that consideration and named it. Kindly suggest!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @0xenn! 🙏
Could you please run the suggested scripts to fix CI errors?
Given that @mui/material
has localization for different Arabic dialects, should we also consider having it separate?
I'm not an expert in Arabic language, so, can't comment on the best approach.
But if it is anything similar to how Norwegian (Bokmål and Nynorsk) differ, then we should probably split it per dialect. 🤔
For languages, where a common form for certain thing is acceptable, I wouldn't mind landing on a generic locale (like having en
instead of enUS
and endGB
, etc.)
@LukasTy Done. Thanks for your feedback.😊 |
What do you think about the localization itself? ar: 'Arabic' in the |
@LukasTy as mentioned by you that @mui/material has as different localization for different countries. In this case also i think it would be much better to have that distinction because there might be slight differences between dialects You can have a look on language code and let me know. Even i don't have that much idea 😅. |
The main issue is consistency. WDYT @mui/xgrid and @mui/material-ui? Does it make sense to segment Arabic locales precisely? 🤔 |
🤣.Understood then it's better to have localization per dialect. In that case which country do i need to specify as i have used generic arabic. |
If it's ok for you, let's wait for any feedback from the tagged teams before proceeding with any changes. 😉
Whichever you need or can provide. 👍 Preferably—the most popular/common. Lines 3 to 5 in 259a3d4
|
Sure No problem. Kindly notify it
Ok. 😁 |
Hey @LukasTy, I asked the Material UI team, and we agree that we should try to keep consistency and follow https://mui.com/material-ui/guides/localization/#supported-locales, which would be best. |
Thanks for the reply @DiegoAndai. 🙏 One could say that we could even rename |
I'm not aware of that issue, but seems like there's no decision there either. |
So that means for now we can go with these three according to https://mui.com/material-ui/guides/localization/#supported-locales right. |
I'm not a native Arabic, however, I speak a language that uses the same alphabet system and many words are common with Arabic. As I understand, although different dialects exist they are very similar in terms of communication and a standard locale could cover more than 99% of the communication. Thus, the proposal in mui/material-ui#31847 makes sense to me, I'd be in favor of doing it for X line of products in v8, and possibly deprecating the country-specific ones aiming to remove them in v9. The core line of products could follow it then. |
Thank you for your input @MBilalShafi. 🙏 Besides, we already have a couple (eu and mk) country independent locales. 👍 @0xenn could you update the PR with the mentioned suggestion (#15693 (comment)) of adding an entry in the |
@LukasTy Done. Thanks |
Fixes #15650