-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @playwright/test to ^1.48.2 #13672
Conversation
Deploy preview: https://deploy-preview-13672--material-ui-x.netlify.app/ |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
55f30cf
to
1a93b7c
Compare
12f8e4d
to
392a1f0
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
392a1f0
to
dae7e91
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
dae7e91
to
8ed5aba
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
8ed5aba
to
ae05bea
Compare
ae05bea
to
c951b16
Compare
@LukasTy it seems this is not taking a picture of the print anymore but of the page |
Good point. 🤔 Are you looking into it? Or shall I? |
@LukasTy I can try looking into it, do you have any context on why we use ffmpeg there? |
@JCQuintas I'm currently checking something. |
@JCQuintas It looks like Playwright or the latest released chromium browser is broken. EDIT: It does open on Firefox. |
test/e2e/index.test.ts
Outdated
// The test is flaky on webkit | ||
if (browserType.name() === 'webkit') { | ||
// The test is flaky on webkit and firefox | ||
if (browserType.name() === 'webkit' || browserType.name() === 'firefox') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one seemed too flaky on firefox, I don't think it's worth spending time on re-running it. 🙈
I've reopened the PR as there are relevant changes that are great improvements. 🤔 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
c6ba660
to
ea6e319
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ea6e319
to
7bda987
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
7bda987
to
0c290be
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@flaviendelangle the argos issue is on the version of playwright itself... the print popup is not opening anymore. I'm not sure if this is an issue on our setup or on their side, the code is technically correct afaik 🙃 The pickers e2e issues I have no idea |
@JCQuintas I have a problem, the version that we use for |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
4b887cd
to
5236ad1
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This PR contains the following updates:
^1.44.1
->^1.48.2
Release Notes
microsoft/playwright (@playwright/test)
v1.48.2
Compare Source
v1.48.1
Compare Source
Highlights
https://github.com/microsoft/playwright/issues/33023 - [Bug]: command line flag --headed has no effect in ui modehttps://github.com/microsoft/playwright/issues/331077 - [REGRESSION]: page.waitForRequest does not get resolved since 1.48.https://github.com/microsoft/playwright/issues/3308585 - [Bug]: WebSocket route does not handle full URLs in Playwrighttps://github.com/microsoft/playwright/issues/33052052 - [Regression]: Inspector not showing recorded sthttps://github.com/microsoft/playwright/issues/331323132 - [Bug]: Wrong Ubuntu release name in Dockerfile.nhttps://github.com/microsoft/playwright/pull/3299632996 - [BUG] Trace attachments have small unusable height
Browser Versions
This version was also tested against the following stable channels:
v1.48.0
Compare Source
v1.47.2
Compare Source
Highlights
https://github.com/microsoft/playwright/pull/32699- [REGRESSION]: fix(codegen): use content_frame property in python/.NEThttps://github.com/microsoft/playwright/issues/327066- [REGRESSION]: page.pause() does not pause test timeout after 1.4https://github.com/microsoft/playwright/pull/3266161 - fix(trace-viewer): time delta between local and remote actions
Browser Versions
This version was also tested against the following stable channels:
v1.47.1
Compare Source
v1.47.0
Compare Source
v1.46.1
Compare Source
v1.46.0
Compare Source
v1.45.3
Compare Source
v1.45.2
Compare Source
v1.45.1
Compare Source
v1.45.0
Compare Source
Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.