[code-infra] Prepare some tests to work in vitest/playwright
#14926
Conversation
JCQuintas
added
test
component: data grid
|
Deploy preview: https://deploy-preview-14926--material-ui-x.netlify.app/ |
JCQuintas
changed the title
test rendering logictest rendering logic
JCQuintas
changed the title
test rendering logicvitest/playwright
| const isColDefWidth114Present = colDefWidthArgs.some((width) => width === 114); | ||
| expect(isColDefWidth114Present).to.equal(true); | ||
| const widthArgs = onColumnWidthChange.args.map((arg) => Math.round(arg[0].width)); | ||
| expect(widthArgs).to.deep.equal([120, 64]); |
There was a problem hiding this comment.
IMHO, this needs a review from xGrid as it looks like something functional has changed. 🤔
There was a problem hiding this comment.
Yeah, the scrollbar is not rendered, so the size is different.
It took me a while to find the actual issue.
As I said, there are two options:
- Test all without scrollbar
- Enable scrollbars to all playwright tests if the scrollbar is important
There was a problem hiding this comment.
Noticed the CI is still erroring on the changes, I might have to go with 2 regardless for this specific error 😓
There was a problem hiding this comment.
As I said, there are two options:
- Test all without scrollbar
- Enable scrollbars to all playwright tests if the scrollbar is important
But why did the behavior of the scrollbar change if the playwright package had not been bumped? 🤔
Is it the same issue blocking us here: #13672?
There was a problem hiding this comment.
No, they are unrelated.
Behaviour is based on the browser arguments, karma is using the playwright browser executable only, and passing its own arguments in, which means it shows scrollbars in headless mode.
Playwright on the other hand, passes their own arguments in, which means it will hide the scrollbars in headless mode .
There was a problem hiding this comment.
I've reverted the changes specific to scrollbar, as the 2nd option seems to fix it cleanly.
There was a problem hiding this comment.
Cool. 👍
LGTM then, I've restarted a flaky unit test. 😉
This reverts commit db554b9.
Porting a change from #14508
Basically making the render independent from other test runs by not having a globally defined variable for the test.
Also removes
done()from two tests 😅### ScrollbarsThe changes on columns.DataGridPro.test.tsx are due to playwright not displaying scrollbars by default.If it is desirable to display the scrollbars, then I can revert this and force playwright to show them in headless mode instead.