Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Deprecate LicenseInfo reexports #11956

Merged
merged 1 commit into from
Feb 6, 2024
Merged

[core] Deprecate LicenseInfo reexports #11956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/grid/x-data-grid-premium/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
import './typeOverloads';

export { LicenseInfo } from '@mui/x-license';
export {
/**
* @deprecated
* Use `@mui/x-license` package instead:
* import { LicenseInfo } from '@mui/x-license';
*/
LicenseInfo,
} from '@mui/x-license';
export * from '@mui/x-data-grid/components';
export * from '@mui/x-data-grid-pro/components';
export * from '@mui/x-data-grid/constants';
Expand Down
9 changes: 8 additions & 1 deletion packages/grid/x-data-grid-pro/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
import './typeOverloads';

export { LicenseInfo } from '@mui/x-license';
export {
/**
* @deprecated
* Use `@mui/x-license` package instead:
* import { LicenseInfo } from '@mui/x-license';
*/
LicenseInfo,
} from '@mui/x-license';
Comment on lines +3 to +10
Copy link
Member

@oliviertassinari oliviertassinari Feb 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't generate IntelliSense for me.

Actual:

How about?

Suggested change
export {
/**
* @deprecated
* Use `@mui/x-license` package instead:
* import { LicenseInfo } from '@mui/x-license';
*/
LicenseInfo,
} from '@mui/x-license';
import { LicenseInfo as LicenseInfoExport } from '@mui/x-license';
/**
* @deprecated Use `@mui/x-license` package instead: import { LicenseInfo } from '@mui/x-license';
*/
export const LicenseInfo = LicenseInfoExport;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I couldn't figure it out!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#11974

export * from '@mui/x-data-grid/components';
export * from '@mui/x-data-grid/constants';
export * from '@mui/x-data-grid/hooks';
Expand Down
9 changes: 8 additions & 1 deletion packages/x-date-pickers-pro/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
export { LicenseInfo } from '@mui/x-license';
export {
/**
* @deprecated
* Use `@mui/x-license` package instead:
* import { LicenseInfo } from '@mui/x-license';
*/
LicenseInfo,
} from '@mui/x-license';
export * from '@mui/x-date-pickers';

export * from './DateRangePickerDay';
Expand Down
Loading