-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Deprecate LicenseInfo
reexports
#11956
[core] Deprecate LicenseInfo
reexports
#11956
Conversation
Deploy preview: https://deploy-preview-11956--material-ui-x.netlify.app/ |
Should we mention it in the migration guide or should we wait for its removal (in v8 I guess)? |
I don't think so, deprecation message should be enough for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't be against a runtime warning, but maybe it's pushing it too far 😄
export { | ||
/** | ||
* @deprecated | ||
* Use `@mui/x-license` package instead: | ||
* import { LicenseInfo } from '@mui/x-license'; | ||
*/ | ||
LicenseInfo, | ||
} from '@mui/x-license'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't generate IntelliSense for me.
How about?
export { | |
/** | |
* @deprecated | |
* Use `@mui/x-license` package instead: | |
* import { LicenseInfo } from '@mui/x-license'; | |
*/ | |
LicenseInfo, | |
} from '@mui/x-license'; | |
import { LicenseInfo as LicenseInfoExport } from '@mui/x-license'; | |
/** | |
* @deprecated Use `@mui/x-license` package instead: import { LicenseInfo } from '@mui/x-license'; | |
*/ | |
export const LicenseInfo = LicenseInfoExport; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I couldn't figure it out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO if we add a runtime warning, then we should add it properly on the migration guide because people would be almost forced to migrate (I don't want to stay with a warning in dev everytime I work on my app). I see 2 ways of approaching this:
|
@flaviendelangle the smoother path makes sense, no need to rush it. |
Closes #11942