Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES locale update #332

Closed
wants to merge 0 commits into from
Closed

Conversation

nonfreegithub
Copy link
Contributor

spanish locale update and templates

@OgelGames OgelGames added the Translations Aims to improve translations. label Nov 5, 2023
@OgelGames
Copy link
Contributor

Why is so much removed/changed? The template for technic in particular should not need to be changed, as it was updated in #289

@nonfreegithub
Copy link
Contributor Author

Why is so much removed/changed? The template for technic in particular should not need to be changed, as it was updated in #289

it was because I use this built-in minetest script

@OgelGames
Copy link
Contributor

OgelGames commented Nov 5, 2023

That explains why some translations are missing, that script doesn't pick up strings generated at runtime, such as the ones here:

local function register_dust(name, ingot)
local lname = string.lower(name)
lname = string.gsub(lname, ' ', '_')
minetest.register_craftitem("technic:"..lname.."_dust", {
description = S("@1 Dust", S(name)),
inventory_image = "technic_"..lname.."_dust.png",
})
if ingot then
minetest.register_craft({
type = "cooking",
recipe = "technic:"..lname.."_dust",
output = ingot,
})
technic.register_grinder_recipe({ input = {ingot}, output = "technic:"..lname.."_dust 1" })
end
end
-- Sorted alphibeticaly
register_dust("Brass", "basic_materials:brass_ingot")
register_dust("Bronze", "default:bronze_ingot")
register_dust("Carbon Steel", "technic:carbon_steel_ingot")
register_dust("Cast Iron", "technic:cast_iron_ingot")
register_dust("Chernobylite", "technic:chernobylite_block")
register_dust("Chromium", "technic:chromium_ingot")
register_dust("Coal", nil)
register_dust("Copper", "default:copper_ingot")
register_dust("Lead", "technic:lead_ingot")
register_dust("Gold", "default:gold_ingot")
register_dust("Mithril", "moreores:mithril_ingot")
register_dust("Silver", "moreores:silver_ingot")
register_dust("Stainless Steel", "technic:stainless_steel_ingot")
register_dust("Stone", "default:stone")
register_dust("Sulfur", nil)
register_dust("Tin", "default:tin_ingot")
register_dust("Wrought Iron", "technic:wrought_iron_ingot")
register_dust("Zinc", "technic:zinc_ingot")
if minetest.get_modpath("gloopores") or minetest.get_modpath("glooptest") then
register_dust("Akalin", "glooptest:akalin_ingot")
register_dust("Alatro", "glooptest:alatro_ingot")
register_dust("Arol", "glooptest:arol_ingot")
register_dust("Kalite", nil)
register_dust("Talinite", "glooptest:talinite_ingot")
end

@nonfreegithub
Copy link
Contributor Author

ok, now I only update the technic.es.tr file

@S-S-X
Copy link
Member

S-S-X commented Nov 5, 2023

Should probably also be sorted like it was before. A lot of removed lines too, is that intentional?

@nonfreegithub
Copy link
Contributor Author

Should probably also be sorted like it was before. A lot of removed lines toois that intentional?

the script orders the lines, I think they were not removed, just ordered, this does not seem to affect the in-game translation

@S-S-X
Copy link
Member

S-S-X commented Nov 5, 2023

the script orders the lines, I think they were not removed, just ordered, this does not seem to affect the in-game translation

There's 157 additions and 186 deletions in this change set. It is not just ordered but bad ordering does make it harder to quickly find out what has been removed. Few lines are comments with original author name but that still leaves over 20 missing lines.

@SwissalpS
Copy link
Contributor

SwissalpS commented Nov 6, 2023

I agree with S-S-X and OgelGames, it's very hard to see what changed when the order is changed.

In a quick read through some parts I found multiple mistakes with capitalisation. In Spanish only proper names are capitalized. e.g. Names of people, places, countries. Not even weekdays and months are capitalized in Spanish, so words like "energia", "reactor nuclear" absolutely should not have capitals. (exceptions are tolerated when it's a title and every word is capitalized)

Edit: I also feel the original author credits should be kept and amended with subsequent editors.

@nonfreegithub
Copy link
Contributor Author

In a quick read through some parts I found multiple mistakes with capitalisation. In Spanish only proper names are capitalized. e.g. Names of people, places, countries. Not even weekdays and months are capitalized in Spanish, so words like "energia", "reactor nuclear" absolutely should not have capitals. (exceptions are tolerated when it's a title and every word is capitalized)

Edit: I also feel the original author credits should be kept and amended with subsequent editors.

The capital letters were already in the original translation, I have not added them.

If I keep the name of the original author I must also add my name

@SwissalpS
Copy link
Contributor

If I keep the name of the original author I must also add my name

yes, you may add your real name but can also use any alias. It helps to show that changes have happened since original version.

The capital letters were already in the original translation, I have not added them.

that is why keeping the order would help. But you may also change them while you are updating the file anyway ;)

@OgelGames OgelGames added the WIP Work in progress label Nov 7, 2023
@SwissalpS
Copy link
Contributor

@nonfreegithub what is your plan? Submitting another clean PR or have you lost interrest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translations Aims to improve translations. WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants