-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES locale update #332
ES locale update #332
Conversation
Why is so much removed/changed? The template for |
it was because I use this built-in minetest script |
That explains why some translations are missing, that script doesn't pick up strings generated at runtime, such as the ones here: technic/technic/machines/register/grinder_recipes.lua Lines 90 to 132 in f1b9928
|
962407c
to
4d9bb7d
Compare
ok, now I only update the technic.es.tr file |
Should probably also be sorted like it was before. A lot of removed lines too, is that intentional? |
the script orders the lines, I think they were not removed, just ordered, this does not seem to affect the in-game translation |
There's 157 additions and 186 deletions in this change set. It is not just ordered but bad ordering does make it harder to quickly find out what has been removed. Few lines are comments with original author name but that still leaves over 20 missing lines. |
I agree with S-S-X and OgelGames, it's very hard to see what changed when the order is changed. In a quick read through some parts I found multiple mistakes with capitalisation. In Spanish only proper names are capitalized. e.g. Names of people, places, countries. Not even weekdays and months are capitalized in Spanish, so words like "energia", "reactor nuclear" absolutely should not have capitals. (exceptions are tolerated when it's a title and every word is capitalized) Edit: I also feel the original author credits should be kept and amended with subsequent editors. |
The capital letters were already in the original translation, I have not added them. If I keep the name of the original author I must also add my name |
yes, you may add your real name but can also use any alias. It helps to show that changes have happened since original version.
that is why keeping the order would help. But you may also change them while you are updating the file anyway ;) |
23d2fd1
to
4d9bb7d
Compare
@nonfreegithub what is your plan? Submitting another clean PR or have you lost interrest? |
spanish locale update and templates