Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dts: msm8952: Add support for Xiaomi Redmi 4A (rolex) #419

Merged
merged 3 commits into from
Sep 3, 2024
Merged

dts: msm8952: Add support for Xiaomi Redmi 4A (rolex) #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41ba7eb
dts: msm8952: Add support for Xiaomi Redmi 4A (rolex)
barni2000 Aug 28, 2024
8c477cf
dts: msm8952: xiaomi-rolex: update msm-id
barni2000 Sep 2, 2024
df3a4ad
dts: msm8952: xiaomi-rolex: Fix panel selector
semfault Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Documentation/devices.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
- Motorola Moto G6 Play (jeter)
- OPPO A57 (A57) (quirky - see comment in `lk2nd/device/dts/msm8952/msm8940-oppo-a57.dts`)
- Redmi 3S (land) (quirky - see comment in `lk2nd/device/dts/msm8952/msm8937-xiaomi-land.dts`)
- Redmi 4A (rolex)
- Redmi 4X (santoni)
- Redmi 5A (riva)
- Redmi Note 3 Pro (kenzo)
Expand Down
33 changes: 33 additions & 0 deletions lk2nd/device/dts/msm8952/msm8917-xiaomi-rolex.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// SPDX-License-Identifier: BSD-3-Clause

/dts-v1/;

#include <skeleton64.dtsi>
#include <lk2nd.dtsi>

/ {
qcom,msm-id = <QCOM_ID_MSM8917 0>;
qcom,board-id = <0x1000b 1>, <0x2000b 1>;
};

&lk2nd {
model = "Xiaomi Redmi 4A (rolex)";
compatible = "xiaomi,rolex";

lk2nd,dtb-files = "msm8917-xiaomi-rolex";

lk2nd,match-panel;
panel {
compatible = "xiaomi,rolex-panel", "lk2nd,panel";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#include "dsi-panel-hx8394f-boe-c3a-720p-video.dtsi"
#include "dsi-panel-nt35521s-ebbg-c3a-720p-video.dtsi"
#include "dsi-panel-ili9881c-ebbg-c3a-720p-video.dtsi"

It seems rolex only have 3 panel variants.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove ebbgDJN variant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And there is no tianma panel you should check dsi-panel-nt35521s-ebbg-c3a-720p-video.dtsi instead of it.
MiCode/Xiaomi_Kernel_OpenSource@2dd7cd8#diff-9af61c7ea9db8f0811d139a90e483bf2ec4493188b2513106d2657c14aadf6d4R20

Copy link
Contributor

@barni2000 barni2000 Sep 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems none of the node names contains c3a. Check c3a panels dtsi.


qcom,mdss_dsi_hx8394f_boe_c3a_720p_video {
compatible = "xiaomi,rolex-hx8394f-boe";
};
qcom,mdss_dsi_ili9881c_ebbg_c3a_720p_video {
compatible = "xiaomi,rolex-ili9881c-ebbg";
};
qcom,mdss_dsi_nt35521s_ebbg_720p_video {
compatible = "xiaomi,rolex-nt35521s-ebbg";
};
};
};
1 change: 1 addition & 0 deletions lk2nd/device/dts/msm8952/rules.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ LOCAL_DIR := $(GET_LOCAL_DIR)

ADTBS += \
$(LOCAL_DIR)/msm8917-mtp.dtb \
$(LOCAL_DIR)/msm8917-xiaomi-rolex.dtb \
$(LOCAL_DIR)/msm8917-xiaomi-riva.dtb \
$(LOCAL_DIR)/msm8937-huawei-aum.dtb \
$(LOCAL_DIR)/msm8937-motorola-jeter.dtb \
Expand Down