dts: msm8952: Add support for Xiaomi Redmi 4A (rolex) #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravMurav
reviewed
Sep 2, 2024
| #include <lk2nd.dtsi> | ||
|
|
||
| / { | ||
| qcom,msm-id = <QCOM_ID_MSM8917 0>, <308 0>, <309 0>; |
There was a problem hiding this comment.
Do you really need msm8217/8617?
Suggested change
| qcom,msm-id = <QCOM_ID_MSM8917 0>, <308 0>, <309 0>; | |
| qcom,msm-id = <QCOM_ID_MSM8917 0>; |
barni2000
suggested changes
Sep 2, 2024
|
|
||
| lk2nd,match-panel; | ||
| panel { | ||
| compatible = "xiaomi,rolex-panel", "lk2nd,panel"; |
There was a problem hiding this comment.
#include "dsi-panel-hx8394f-boe-c3a-720p-video.dtsi"
#include "dsi-panel-nt35521s-ebbg-c3a-720p-video.dtsi"
#include "dsi-panel-ili9881c-ebbg-c3a-720p-video.dtsi"
It seems rolex only have 3 panel variants.
There was a problem hiding this comment.
And there is no tianma panel you should check dsi-panel-nt35521s-ebbg-c3a-720p-video.dtsi instead of it.
MiCode/Xiaomi_Kernel_OpenSource@2dd7cd8#diff-9af61c7ea9db8f0811d139a90e483bf2ec4493188b2513106d2657c14aadf6d4R20
There was a problem hiding this comment.
It seems none of the node names contains c3a. Check c3a panels dtsi.
rolex only has 3 panel variants (hx8394f, nt35521s, ili9881c). Signed-off-by: Gabriel Gonzales <[email protected]>
semfault
force-pushed
the
fix-conflict
branch
from
8b2b667
to
df3a4ad
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.